Repository navigation
fix(pdf): a PDF error shows a message instead of freezing; fall back to the default font (6.4.x) - #254
Closed
RensTillmann wants to merge 1 commit into
Closed
fix(pdf): a PDF error shows a message instead of freezing; fall back to the default font (6.4.x)#254RensTillmann wants to merge 1 commit into
RensTillmann wants to merge 1 commit into
Conversation
…to the default font (6.4.x)
Owner
Author
|
The fix is already released in 6.4.010 (release PR #299, merged 21 Oct 2026): SUPER.pdf_generator_abort and the font retry/default-font fallback are in src/assets/js/common.js (from line 11752); the code is identical apart from comments. This PR's test file tests/test-pdf-generator-client.cjs was not part of that release and stays on this branch. The browser suite covers this on 6.4.010 (pdf-error-and-debug.spec.ts, passed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two PDF Generator fixes for 6.4:
SUPER.pdf_generator_abort(): rejectedhtml2canvasrenders (page render and the flag-image render in prepare, both had no.catch), JavaScript errors while building a page (the catch only logged), and errors in init, prepare and page determination. Abort logs to the console, restores the form and the submit button, shows a translatable message with the Close button, and sends nothing. Message: "We couldn't create the PDF, so your form has not been sent yet. Please try again." (newloadingOverlay.pdf_generation_error). It runs once; a render that finishes after an abort does not submit; an error from the submit step after the PDF is done is not shown as a PDF error.SUPER.pdf_generator_start()so both branches use it.No timeout was added. Debug mode is unchanged (already does not submit on 6.4).
Part of #102. The 6.3 LTS counterpart is #251.
Base branch
release/6.4.x: bug fixes for the beta channel (frozen: security and bug fixes only).Tests
Not run: a real-browser PDF submission.
src/docs/changelog.mdadds "Unreleased - Version 6.4.010-beta"; #250 adds the same heading, so expect a one-line changelog conflict when both land.Merge
Draft: for QA and the next 6.4.0xx release session.