Skip to content

fix: a field inside an invisible column no longer blocks the form silently (6.3 now matches 6.4) - #271

Merged
RensTillmann merged 2 commits into
lts/6.3.xfrom
fix/lts-invisible-column-validation
Oct 20, 2026
Merged

RensTillmann merged 2 commits into
lts/6.3.xfrom
fix/lts-invisible-column-validation

Conversation

@RensTillmann

@RensTillmann RensTillmann commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

On 6.3 LTS a required/validated field inside a Column set to invisible blocked the form silently: the browser validated it and marked it "Field is required!", but the field is invisible, so the visitor saw no message and nothing was sent (confirmed in a real browser on 6.3.322). 6.4 skips such fields.

Now 6.3 does the same as 6.4: has_hidden_parent() gets the includeInvisibleColumns parameter (default true), used only by validate_form; every other caller (conditional logic, tag replacement, auto-step, payload collection, navigation, calculator) passes false, false so its behaviour is unchanged. Fields in invisible columns are still submitted. The server skips invisible-column subtrees in collect_required_fields() (same as #250 on 6.4).

Base branch

lts/6.3.x: bug fix.

Tests

tests/test-invisible-column-client.cjs (real common.js in node:vm): without fix 3 of 4 fail, with fix 4/4
tests/test-security-required-fields-invisible-column.php: without fix 2 of 5 fail, with fix 5/5
full LTS PHPUnit suite: OK, 669 tests; all client tests 43/43

Interaction: the Enter-key fix #265 now passes explicit has_hidden_parent(..., false, false) so a submit button in an invisible column keeps working with this change.

Merge

Draft: for QA and the next LTS release session.

@RensTillmann
RensTillmann marked this pull request as ready for review October 20, 2026 16:01
@RensTillmann
RensTillmann merged commit 3f5183d into lts/6.3.x Oct 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant