Skip to content

Abort PDF generation with an error after 120 s or when rendering fails (6.3) - #282

Closed
jill-fleet[bot] wants to merge 1 commit into
lts/6.3.xfrom
fix/pdf-generator-watchdog-6.3
Closed

jill-fleet[bot] wants to merge 1 commit into
lts/6.3.xfrom
fix/pdf-generator-watchdog-6.3

Conversation

@jill-fleet

@jill-fleet jill-fleet Bot commented Oct 20, 2026

Copy link
Copy Markdown

Type: fix

PDF generation could hang with the loading overlay shown forever when html2canvas never finished or was rejected.

  • Adds a 120 s watchdog around PDF generation.
  • Adds a catch on the html2canvas promise.
  • Both paths call a new abort helper that resets the form and shows an error in the loading overlay (new i18n string pdf_generation_error).

Hand port; no JS tests exist for this code. Untested in a browser. PHP touched (one i18n string).

@RensTillmann

Copy link
Copy Markdown
Owner

Partly released in 6.3.323 (release PR #294, merged 20 Oct 2026): stopping on a rendering failure, with an error and without sending the form, shipped through PR #251 (assets/js/common.js line 7999, pdf_generator_abort, called at lines 791, 7953, 8325 and 8521), with a newer error text. NOT released: this PR's 120-second watchdog (_pdfTimeoutId); it stays on this branch for reference. This PR conflicts with the released code, so a watchdog would need a fresh change on top of 6.3.323.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant