Repository navigation
Abort PDF generation with an error after 120 s or when rendering fails (6.3) - #282
Closed
jill-fleet[bot] wants to merge 1 commit into
Closed
jill-fleet[bot] wants to merge 1 commit into
jill-fleet[bot] wants to merge 1 commit into
Conversation
Owner
|
Partly released in 6.3.323 (release PR #294, merged 20 Oct 2026): stopping on a rendering failure, with an error and without sending the form, shipped through PR #251 (assets/js/common.js line 7999, pdf_generator_abort, called at lines 791, 7953, 8325 and 8521), with a newer error text. NOT released: this PR's 120-second watchdog (_pdfTimeoutId); it stays on this branch for reference. This PR conflicts with the released code, so a watchdog would need a fresh change on top of 6.3.323. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: fix
PDF generation could hang with the loading overlay shown forever when html2canvas never finished or was rejected.
pdf_generation_error).Hand port; no JS tests exist for this code. Untested in a browser. PHP touched (one i18n string).