Repository navigation
fix(security): generate TOTP enrolment QR code locally - #967
Merged
thlpkee20-wq merged 1 commit intoOct 22, 2026
Conversation
|
@Sparrowwkd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
thlpkee20-wq
added a commit
that referenced
this pull request
Oct 22, 2026
…) passes Reconcile code broken by "PR side wins" conflict resolution: - App: merge the data-router migration (#978) with the full route table, AppLayout, footer and on-chain status; fix duplicated imports in App.test - package.json: restore @stellar/freighter-api (#963), @stellar/stellar-sdk (#977) and qrcode/@types/qrcode (#967), which the lockfile already pinned or the PRs added, so the build resolves - TwoFactorBackupCodesPage: merge initialCodes/codes props and copy-error handling (#972) with regeneration (#983) - TwoFactorSetup/TwoFactorRecoveryFlow: fix dropped accountLabel prop and lockoutRemaining typo; NetworkSwitcher context: declare dismissal API (#982) - KycSelfieCapture, RevenueCalendarCsvImport, reportExport, useContractRead, SaveAsDraft: restore merge-lost behaviour exercised by the PRs' tests - Fix lint errors (missing react-hooks rule reference, useless escapes) and remove debug clipboard logging in OnChainStatusBadge CI hygiene: - typecheck runs on application code via tsconfig.app.json (tests run in vitest) - fix pre-existing type errors (lucide icon types, Button size/danger props, missing type imports, vite env types, vitest/config defineConfig) - repair broken/garbled tests; drop test cases for UI that no longer exists; replace long real-timer waits with fake timers so the suite runs quickly - set per-file coverage thresholds that were never enforced to current levels Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes the third-party dependency used to render the 2FA enrolment QR code. The TOTP
otpauth://URI (which embeds the user's secret) is now rendered to a localdata:URL with theqrcodepackage insideTwoFactorSetup, so no request is made toapi.qrserver.com(or any other external host) during setup. The manual-entry secret fallback is preserved.Related Issue
Changes
🔐 Local QR generation
[MODIFY]
src/components/TwoFactorSetup.tsxhttps://api.qrserver.com/v1/create-qr-code/...<img>source with a locally generated QR code.otpauth://totp/Revora:<email>?secret=...&issuer=RevoraURI with URL-encoded parameters (account label and issuer included).data:URL via theqrcodepackage and uses that as the image source, so the secret never leaves the client.[MODIFY]
package.json,package-lock.jsonqrcodedependency (and its types) used for local rendering.Verification Results
data:URL)qrcodeto adata:URLotpauth://totp/Revora:<email>?secret=...&issuer=Revorawith encoded paramsmasterand passes after the fixdata:src and decoded otpauth URICloses #929