Repository navigation
fix(sessions): handle revoke failures instead of hanging in Revoking state - #974
Merged
thlpkee20-wq merged 2 commits intoOct 22, 2026
Merged
Conversation
|
@temisan0x Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #936
What was broken
handleRevokeSingleandhandleRevokeAllawaited the revoke callbacks with no error handling. If the request failed, the dialog stayed stuck on "Revoking..." forever and the rejection went unhandled, so the user couldn't retry and had no idea the session was still active.What this changes
try/catch/finally, and the pending flags are cleared infinally..sm-dialog-errorstyle for the inline message.Tests
New
SessionManagement.test.tsxcovers:The failure-path tests fail on current
masterand pass with this fix.One thing I noticed (not changed)
On a successful revoke-all,
setSessions((prev) => prev.filter((s) => !s.isCurrent))removes the current session from the list instead of the others. That looks backwards, but it's outside this issue's scope, so I left it alone.