test(dl-reconcile): pin delimiter shape and comment indent (RIG-3944) - #1331
Open
rigel-mintaka wants to merge 2 commits into
Open
rigel-mintaka wants to merge 2 commits into
rigel-mintaka wants to merge 2 commits into
Conversation
Two mutations survived the suite: loosening `isLedgerSeparator` to a bare 4-cell check, and relaxing the comment opener to any indent. Each now fails exactly one new test. - A 4-cell row under the header that is not a delimiter row yields no parser rows against a floor of 1. - A comment opener indented four spaces is indented code, so the row it wraps stays content: parser 1, floor 2. Refs RIG-3944 Co-authored-by: Matt Wilkinson <matt@rigel.build>
This was referenced Sep 25, 2026
|
Compass engineering docs preview: https://compassdlreconcile-rig-3944.compass-eng-docs.pages.dev Deployed from |
Review found two more survivors on the same checks: tightening the comment opener to `/^<!--/` and dropping the 4-cell count from `isLedgerSeparator`. Both agreed silently on a phantom row. A 3-space comment opener and a 3-cell delimiter row now fail them. Refs RIG-3944 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
added this pull request to stack #1328
September 25, 2026 16:02
rigel-mintaka
marked this pull request as ready for review
September 25, 2026 16:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 3 PRs:
mainTwo mutations survived the suite: loosening
isLedgerSeparatorto a bare 4-cell check, and relaxing the comment opener to any indent. Each now fails exactly one new test.Review found two more mutations on the same checks that let the counters agree silently on a phantom row: tightening the opener to
/^<!--/and dropping the 4-cell count. Both are now pinned.Each of the four mutations fails only its own test (45 pass / 1 fail). All expectations were checked against GitHub's GFM renderer.
Refs RIG-3944
Co-authored-by: Matt Wilkinson matt@rigel.build