Repository navigation
feat(forge): carry PR head SHA, mergeable state and review commit id (RIG-5182) - #2194
Merged
Merged
Conversation
…(RIG-5182) GitHub's pull detail and review rows already return head.sha, mergeable_state and commit_id. Decode them into forge.PullRequest and forge.Review, and copy them into the head_sha, mergeable_state and commit_id proto fields so the stored pr JSONB carries them. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
😎 This pull request was merged. |
|
Compass engineering docs preview: https://compass-forge-rig-5182-pr-fi.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
marked this pull request as ready for review
October 11, 2026 21:34
rigel-mintaka
added this pull request to stack #2220
October 12, 2026 01:28
mattwilkinsonn
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
mainSummary
Status board T14 (RIG-5182): the GitHub reader keeps three fields it already receives and the stored
prJSONB now carries them.forge.PullRequestgainsHeadSHA(fromhead.sha) andMergeableState(frommergeable_state).forge.ReviewgainsCommitID(from the review row'scommit_id).TranslatePullRequest/translateReviewscopy them tohead_sha,mergeable_stateandReview.commit_id(proto fields added in feat(proto): add status board messages and PR/tracker fields (RIG-5169) #2181).Tests
TestGetPullRequestHappyand the golden fixtures decode the three fields from GitHub responses. Mutation: dropping themergeable_statecopy fails both.TestTranslatePullRequestRoundTripcovers the wire copy.TestPullRequestFieldsSurviveStoredPRRoundTrip(pgtest): the fields survive the storedprJSONB, and a row stored without them decodes empty.Notes
No other provider produces PRs; Linear has no PR reads.