Repository navigation
docs(design)!: agent OTLP rides the agent socket to a host collector (RIG-4611) - #2205
rigel-mintaka wants to merge 8 commits into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Compass engineering docs preview: https://compass-obs-rig-4611-agent-c.compass-eng-docs.pages.dev Deployed from Changed pages: |
Review result (head b7566c4)The review followed
No open findings. OQ1–OQ4 are with Matt in RIG-5237. |
b7566c4 to
db3d689
Compare
|
Review loop on the RIG-5237 rewrite. Head 8f7f9e2.
R5 was past K=3, and its fix was one bounded rule plus a test case, so there was no further round. 8f7f9e2 renames the decision file to DL-515 (lane-claimed id). The ledger gate is OK. |
Amendment to the observability architecture: the collector gains an otlphttp upstream exporter, agents reach it over a pinned pasta loopback forward, and devenv runs the same rendered config. Spec-impact: none. Refs RIG-4611 Co-authored-by: Matt Wilkinson <matt@rigel.build>
pasta_options canary, agent endpoint precedence via COMPASS_OTLP_ENDPOINT, host env scrub, preflight seam, endpoint query rejection, header rotation, --otel-external reconciled with D3, and settled OQs moved to constraints. Spec-impact: none. Refs RIG-4611 Co-authored-by: Matt Wilkinson <matt@rigel.build>
Agents get --otel-external via the runner, inherited OTEL_* are dropped from stack children, --otel-off replaces dummy endpoints in tests, and the pasta checks run support-first through one interface. Spec-impact: none. Refs RIG-4611 Co-authored-by: Matt Wilkinson <matt@rigel.build>
External auth via the headers file, shared endpoint validation for the runner flag, and an explicit off state reaching agents. Spec-impact: none. Refs RIG-4611 Co-authored-by: Matt Wilkinson <matt@rigel.build>
…(RIG-4611) Rewrite around Matt's RIG-5237 rulings: a collector per runner host, OTLP/HTTP over the agent socket stamped by the Runner gateway. Lifts the effect-otel no-socket ruling for agent telemetry; records DL-514. Spec-impact: none. Refs RIG-4611 Co-authored-by: Matt Wilkinson <matt@rigel.build>
Spec-impact: none. Refs RIG-4611 Co-authored-by: Matt Wilkinson <matt@rigel.build>
…d (RIG-4611) Spec-impact: none. Refs RIG-4611 Co-authored-by: Matt Wilkinson <matt@rigel.build>
…G-4611) Spec-impact: none. Refs RIG-4611 Co-authored-by: Matt Wilkinson <matt@rigel.build>
8f7f9e2 to
c0753ea
Compare
Summary
Amendment record for agent OTLP routing (
docs/designs/observability/compass-agent-collector-routing/design.md). It is rewritten around Matt's RIG-5237 rulings, which are recorded as DL-515.--otel-external)./v1/traces,/v1/metricsand/v1/logs. It stamps the boundcompass.session.id,compass.telemetry.origin=agentandservice.name=compass-agent, then relays to the host collector. There is no OTLP egress, and the socket stays the agent's only channel.LoopbackForward, the canary, and the old OQ3/OQ4.Tasks: CA1, CB1, CB2, CB3, CC1, CD1. All open questions are resolved in the record; none needs Matt.
Verification
rumdl checkis clean on the record and DL-515.design-ledger-gate:checkis OK.Review: a design-critic pass (14 findings) and review rounds R4 (16 findings) and R5 (1 high) are folded. See the review comment.
Risks
Compatibility
Breaking for operators:
--otel-externaltakes a URL;Implementation tasks carry the migrations.
Documentation
CD1 updates the operator docs.
Ledger-impact: DL-515 (
docs/designs/decisions/observability/DL-515.md).Spec-impact: none