Repository navigation
ci(pgtest): raise the job timeout to 30 minutes (RIG-5324) - #2247
Merged
Merged
Conversation
Successful pgtest jobs now take 17.7 to 19.4 minutes. The -race real-Postgres suite alone takes about 17 minutes, and the sqlc-vet bootstrap still runs after it. Two recent jobs were cancelled at 20.2 and 20.4 minutes. In the #2244 run, all 11 Postgres packages had reported ok before the cancel landed during the sqlc-vet bootstrap. Thirty minutes leaves about ten minutes of headroom over the slowest passing run. The per-package go test -timeout of 15m still catches a wedged suite. Ledger-impact: none (CI timeout only; no recorded decision covers it) Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
😎 This pull request was merged. |
Contributor
Author
…ord (RIG-5324) Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-native-rig-5324-pgte.compass-eng-docs.pages.dev Deployed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgtestjob'stimeout-minutesfrom 20 to 30.-racereal-Postgres suite alone takes about 17 minutes, and the sqlc-vet bootstrap runs after it.Verification
actionlint .github/workflows/ci.yml: clean.ci.ymlruns (gh run viewstart and end times of the pgtest job).Risks
A truly wedged job now holds a runner 10 minutes longer before it is cancelled. The per-package
go test -timeout 15mstill panics a stuck package first. Rollback is to revert this one line.Compatibility
None: CI configuration only. The rollup still requires pgtest to succeed.
Documentation
None:
docs/architecture/build-and-ci.mddoes not document the pgtest limit.Ledger-impact: none (CI timeout only; no recorded decision covers it)