Repository navigation
ci(compass): give the pgtest suite a 25m go test bound (RIG-5325) - #2301
Merged
Merged
Conversation
|
😎 This pull request was merged. |
|
Compass engineering docs preview: https://ci-rig-5325-pgtest-timeout.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
marked this pull request as ready for review
October 15, 2026 07:24
mattwilkinsonn
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgtest's
internal/storetest binary hit the 15mgo test -timeouton #2285 and #2290 (900s). The same package took 665s on main and 733s one run earlier, and no test hung (timings on RIG-5325). Shared-runner variance now spans the whole margin.go test -timeout15m → 25m.timeout-minutes30 → 40, so the job bound still sits above the go test bound plus the bootstrap steps.Sharding
internal/storeis the deferred pgtest-sharding question in the compass CI PR-speed design record. This PR does not shard it.Verification
actionlint: same 17 findings as main, no new ones.