Repository navigation
test(ui): count .conv-stream padding in the scroll test's scrollHeight - #2449
Conversation
|
😎 This pull request was merged. |
74db4a6 to
da29e34
Compare
|
Review at head da29e34 (rebased onto main 23b79aa after the virtual-core stack merged): high 0, medium 0, low 2. Low 1 (setup comment still said scrollHeight = content height) is fixed in this head. Low 2 suggested asserting the stub's own scrollHeight. Not taken: that would test the fixture against itself, not any component behaviour. The reviewer confirmed the padding model (scrollHeight includes padding; clientHeight already does). Local: ChannelView tests 495/495, biome clean. |
|
Compass engineering docs preview: https://compass-native-rig-5818-scro.compass-eng-docs.pages.dev Deployed from |
da29e34 to
518092e
Compare
|
Review at head 518092e (rebased onto main after #2433's comment trims; took main's file and re-applied only the padding change, 7+/3-): high 0, medium 0, low 0 open. The earlier stale-comment low is gone, because #2433 removed that comment. Local: ChannelView tests 495/495, compass-ui:ci pass, biome clean. |
Summary
The scroll test's geometry stub now counts
.conv-stream's vertical padding inscrollHeight(RIG-5818).A browser's
scrollHeightincludes the scroller's padding..conv-streamhas 12px top and bottom (apps/ui/src/app.css). The stub returned only the sizer height, so its max scroll was 24px short. ThescrollTopclamp from #2444 therefore stopped end-scroll writes early. The stub now adds the padding before flooring atclientHeight.Test-only change, based on main (the virtual-core stack #2411, #2444, #2445 has merged).
Verification
bun test --conditions browser src/components/inapps/ui: 495 pass, 0 fail.moon run compass-ui:cipasses. biome is clean.Risks
None at runtime. No current test asserts the exact bottom offset, so this corrects the fixture rather than turning a test red or green.
Compatibility
No change.
Documentation
None.
Ledger-impact: none (test fixture only)