Repository navigation
🐛 Explain cancelled browser operations - #30
Merged
Merged
Conversation
Distinguish deadlines from invalidated capture contexts so real browser failures can be diagnosed without hiding races behind retries. Preserve cancellation behavior and redact the private browser connection.
Robdel12
force-pushed
the
rd/capture-context-fix-20261111
branch
from
November 11, 2026 20:16
d10deb9 to
dfa3329
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Vizzly CI sometimes reports a screenshot cancelled in under a second as “cancelled or exceeded its deadline.” That hides the distinction between a real timeout and an invalidated execution, document, or viewport.
Approach
Keep the existing cancellation and stale-image checks. Report the actual abort reason, including which capture context fields changed and the actual observed viewport/DPR transition, while still redacting the private browser connection URL. This makes the underlying race diagnosable without retries or a longer deadline.
Evidence
The complete local suite passes: 239 tests, with the two WebKit-only cases skipped in the Chromium run. The real browser-pool cancellation test now verifies the reason reaches the caller. This improves diagnostics; it does not claim to fix the unresolved capture race.