1.18.0: Trinket Lab reaches the Great Vault, crafted level is a choice - #24
Merged
Merged
Conversation
- Great Vault on by default: Mythic+ trinkets run up to the vault's level (Myth 6/6) instead of stopping at the dungeon chest's Hero track; the chest level stays one of their steps. Track and level can be chosen or turned off. - Crafted item level is a dropdown of the item levels the season uses, up to the crafting cap SimC's own profiles craft to, instead of a free number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mythic+ trinkets can reach the Myth track through the Great Vault (on by default, track and level selectable); crafted item level is chosen from the season's item levels up to the crafting cap.
Tested: npm test (174 pass), panel checked in the app: vault on gives 2,710 trinket/item level pairs (M+ trinkets up to 334), off gives 2,383 as before; crafted dropdown defaults to 331.
🤖 Generated with Claude Code