1.19.0: No caps on how much a job simulates - #25
Merged
Merged
Conversation
The app runs on your own PC, so it no longer refuses a job for its size: - Trinket Lab (8,000), Weapon Lab (2,400), Upgrade Finder (800 candidates), Crest Planner (120 upgrades), 256 runs per job and 128 enchant combinations are all gone; the count before a run says how much it will be. - SimC runs have no time limit (1 hour, 6 hours for profilesets); Cancel stops them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes every size cap on a job (Trinket Lab 8,000, Weapon Lab 2,400, Upgrade Finder 800, Crest Planner 120, 256 runs per job, 128 enchant combinations) and the SimC run time limit; Cancel stops a job. The 5-job queue stays.
Tested: npm test 174 pass; the Trinket Lab request that failed (all specs, 3 scenarios, 2,710 pairs) now previews as 108 SimC runs.
🤖 Generated with Claude Code