1.20.0: Trinket report in the website's design, 1/3/5 target tabs, set trinkets both ways - #26
Merged
Merged
Conversation
…t trinkets both ways - The Trinket Lab page now wears mythicpersona.com's weapon tier list design, with its two fonts (SIL OFL) inside the file. - A job run with "Also compare 3 and 5 targets" shows tabs for each target count, switched with radio buttons and CSS alone (no script). - A trinket that completes an item set is simulated and listed twice: with the set bonus, and with it switched off (set_bonus=<set>_<n>pc=0). - Verified end to end through the UI: LightMovement with the target matrix reached SimC as fight_style=LightMovement with 1, 3 and 5 enemies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Trinket Lab report now looks like mythicpersona.com/weapon-tier-list (fonts embedded), switches between 1/3/5 targets without a script, and lists a set-completing trinket with and without its set bonus.
Tested: npm test 176 pass. Real run through the UI (Arms, LightMovement, target matrix, 1,000 iterations): SimC reports fight_style=LightMovement with 1/3/5 enemies; baseline 240k/408k/548k; Zul'jin's Guillotine Technique with/without the Bite of Zul'jan bonus +9.45/+8.82% (1t) and +9.53/+6.65% (5t). The page was checked in a browser: tabs switch, fonts load, no overflow.
🤖 Generated with Claude Code