Repository navigation
1.36.0: Crafted gear in every legal stat pair; slots that lost show their best tested item - #49
Merged
Merged
Conversation
…st show their best tested item Crafted pieces with open secondary stats (the placeholder stats 24 and 25) are now candidates in every legal pair instead of only the pair chosen in the form. "All combinations" is the default; one pair, or a list, still narrows it. A piece with fixed stats is one candidate with no pair bonus, since a pair would change nothing on it. The pairs of one piece count as one item in the final round and in the result lists, which keep its best pair. A slot where nothing beat the worn gear used to read "Nothing measured beat it", the same as a slot that was never searched. The report's slot cards and the app's overview now name the best item measured for it, final round over screening. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
A Fury Warrior's Upgrade Finder report had no cloak in it. The crafted Silken Shroud had been simulated (+0.31% in screening, -0.15% in the final round), but nothing said so, and only one of its six stat pairs was tried.
Tested
node --test tests/*.test.mjs: 233 pass, with new tests for the pair candidates, fixed stats, finalists, collapsing and the best-tested note.Version 1.36.0 conflicts on the version files with #48 (1.35.1), whichever merges second.
🤖 Generated with Claude Code