Skip to content

1.36.0: Crafted gear in every legal stat pair; slots that lost show their best tested item - #49

Merged
Roburmaster merged 1 commit into
mainfrom
crafted-all-stat-pairs
Oct 5, 2026
Merged

Roburmaster merged 1 commit into
mainfrom
crafted-all-stat-pairs

Conversation

@Roburmaster

Copy link
Copy Markdown
Owner

What

  • Crafted gear is tried in every legal stat pair. A crafted piece with open secondary stats (the placeholder stats 24/25) is now a candidate in all six pairs, not only the pair picked in the form. "All combinations" is the default; one pair, or a list, still narrows it.
  • Fixed-stat crafted pieces take no pair. 27 of the 98 epic crafted pieces (for example Sunfire and Arcanoweave cloaks) have fixed stats; they were labelled with a pair that did nothing for them. They are now one candidate each.
  • The pairs of one piece are one item in the final round (one place in the slot's share and in the size, every pair that could win goes on with it) and in the result lists, which keep its best pair.
  • A slot that lost shows its best tested item. Before, "Nothing measured beat it" read the same as a slot that was never searched. The report's slot cards and the app's overview now name the best item measured for the slot, final round over screening.

Why

A Fury Warrior's Upgrade Finder report had no cloak in it. The crafted Silken Shroud had been simulated (+0.31% in screening, -0.15% in the final round), but nothing said so, and only one of its six stat pairs was tried.

Tested

  • node --test tests/*.test.mjs: 233 pass, with new tests for the pair candidates, fixed stats, finalists, collapsing and the best-tested note.
  • The report regenerated from a real job, and the app's overview and form checked in the browser (370 candidates for all pairs against 165 for one).

Version 1.36.0 conflicts on the version files with #48 (1.35.1), whichever merges second.

🤖 Generated with Claude Code

…st show their best tested item

Crafted pieces with open secondary stats (the placeholder stats 24 and 25) are now candidates in every legal pair
instead of only the pair chosen in the form. "All combinations" is the default; one pair, or a list, still narrows
it. A piece with fixed stats is one candidate with no pair bonus, since a pair would change nothing on it. The pairs
of one piece count as one item in the final round and in the result lists, which keep its best pair.

A slot where nothing beat the worn gear used to read "Nothing measured beat it", the same as a slot that was never
searched. The report's slot cards and the app's overview now name the best item measured for it, final round over
screening.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Roburmaster
Roburmaster merged commit 196f06b into main Oct 5, 2026
5 checks passed
@Roburmaster
Roburmaster deleted the crafted-all-stat-pairs branch October 5, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant