Skip to content

fix: improve application logging #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helrond merged 2 commits into from
Oct 6, 2026
Merged

fix: improve application logging #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84191ad
add logging
helrond Oct 6, 2026
2ffbb5c
update tests
helrond Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
SourceAgentPerson, SourceArchivalObject,
SourceResource, SourceSubject)

logger = logging.getLogger()
logger.setLevel(getenv('LOGGING_LEVEL', logging.INFO))


def get_config(environment, aws_region, service_name):
"""Fetch config values from SSM Parameter Store by path."""
Expand Down Expand Up @@ -194,24 +197,31 @@ def send_error_message(self, exception, object_type, object_id):
})

def run(self, object_type, data):
logging.debug(f"Running transform for {object_type} {data['uri']}")
try:
from_resource, mapping, schema_name = self.get_mapping_classes(
object_type)
transformed = self.get_transformed_object(
data, from_resource, mapping)
logging.debug(f"Object {data['uri']} transformed")
transformed['online_pending'] = self.get_online_pending(
data.get("instances", []),
transformed.get("online", False))
logging.debug(f"Online pending set for object {data['uri']}")
self.validate_transformed(transformed, schema_name)
logging.debug(f"Transformed object {data['uri']} validated")
self.send_success_message(transformed, object_type)
logging.info(f"Transformation for {object_type} {data['uri']} complete")
except Exception as e:
logging.error(e)
self.send_error_message(
e, object_type, identifier_from_uri(
data['uri']))


def lambda_handler(event, context):
"""Process SQS batch."""
logger.info("Message batch received.")

transformer = Transformer()

Expand Down
4 changes: 2 additions & 2 deletions tests/test_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ def test_run(
mock_online_pending.return_value = False
mock_validate.return_value = True

self.transformer.run('agent_person', {})
self.transformer.run('agent_person', {"uri": "54321"})

mock_mapping.assert_called_once_with('agent_person')
mock_get_transformed.assert_called_once_with(
{}, SourceAgentPerson, SourceAgentPersonToAgent)
{"uri": "54321"}, SourceAgentPerson, SourceAgentPersonToAgent)
mock_validate.assert_called_once_with(
transformed_object, self.transformer.config['SCHEMA_AGENT'])
mock_success_message.assert_called_once_with(
Expand Down