fix: stop infinite update-restart loop in release binaries - #45
Merged
Merged
Conversation
Release artifacts embedded a stale version (Cargo.toml frozen at 1.20.8 while tags advanced) so self_update always reported an update and the app restarted forever. Version stamping is now version-agnostic, the package version is repaired to the latest tag, the updater restarts at most once per update, the Windows restart path compiles again, and CI actually cross-compiles per matrix target.
Owner
Author
Review-fix loop summaryLoop completed after 1 review iteration with no high/medium findings.
VerdictNo high/medium findings remain. |
Owner
Author
|
🎉 This PR is included in version 1.20.28 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release binaries looped through update → restart forever on launch.
Root cause: version-stamping seds in
.releasercandpipe.yamlmatched only the literal0.0.0, soCargo.tomlfroze at1.20.8while tags advanced to1.20.27. Every artifact reported the stale version, soself_updatealways returnedUpdated.Changes:
.releaserc,pipe.yaml); package version repaired to1.20.27(Cargo.toml+Cargo.lock)BINVEC_UPDATEDmarker) — a stale binary can no longer loop foreverexec()unified onio::Errorso the restart path compiles againbuild/build-featurejobs actually cross-compile via--target+ per-target linkers instead of shipping the host binary under five namesVerified: repro script failed pre-fix / passed post-fix; new seds tested;
cargo fmt+cargo checkclean;updater.rstype-checks forx86_64-pc-windows-gnu;cargo check --target aarch64-unknown-linux-gnupasses; workflow YAML parses.