Repository navigation
Conversation
Owner
|
师傅,有几个问题,师傅有空的话修完之后,我在师傅合并pr
|
dunvu0
force-pushed
the
feat/english-ui-foundation
branch
from
November 3, 2026 09:20
49f3b96 to
702cdc9
Compare
Author
|
@RuoJi6 Thanks for the review. I've updated the PR to address both points:
The branch is rebased on the current The PR description has the full details and validation steps. The CI workflow needs your approval to run because this PR comes from a fork 🤖 Generated with Claude Code |
Localize the remaining feature screens, nested dialogs, toasts and known backend errors behind the existing opt-in selector; Chinese stays default. - Catalogs cover tasks, chat, findings/cases, assets, traffic/evidence, Repeater, schedules, asset sync, workspace, agents, LLM, MCP, skills, tools, notifications, interception/approvals, logs and settings. - Known server writeErr texts and backend system labels translate at the display boundary; unknown errors, stored values and raw evidence stay verbatim. Bundled Agent/rule metadata translates only when unchanged. - Fragmented JSX strings become whole ICU messages with plurals. - The language selector also stores output_language so agents and the task report write English when English is selected. Prompt versions are never modified. - Fix the language dropdown layout in the sidebar. - Tests: catalog/ICU checks, i18n unit tests, Go output-language tests, and Playwright coverage for every screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CI runs Node 22 (npm 10), which requires next-intl's nested @swc/helpers@0.5.23 to be recorded in the lockfile. The previous lockfile was written by npm 11 and omitted it, so npm ci failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dunvu0
force-pushed
the
feat/english-ui-foundation
branch
from
November 5, 2026 16:25
ea688fa to
4728f3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional English UI to ARTEX. Chinese remains the default; English is an explicit choice in the language selector.
This update addresses the review feedback on the first version:
What is translated, what stays verbatim
web/messages/{zh-CN,en}.json(4,174 semantic messages each, ICU plurals for counts).writeErrinserver/*.go) and backend-generated system labels are translated at the display boundary. Unknown errors and error details are shown unchanged.Agent output language
Switching the selector to English also saves
output_language=enin settings (GET/PUT /api/settings). Agents then receive an English output directive at runtime, and the task Report tab uses English headings. Stored prompt versions are not modified, and Chinese (zh) remains the default.Implementation
next-intlwith semantic keys and a client provider compatible with the static export. No locale routes or middleware.localStorage; missing or invalid values fall back to Chinese.web/I18N.mddocuments coverage, how to add messages, the checks, and translation attribution (ScopeWeaver, artex-global).Rebased on current
main(d36e1c3), including the new DeepSeek Search API settings and the Jev model-list change.Validation
npm run i18n:check: 4,174 messages, matching keys and ICU arguments.npm run test:i18n: 22 tests, including drift checks against backend error texts, Agent seeds and system labels.npm run build:staticand TypeScript: all static pages export.npm run test:i18n:browser: 60 Chromium tests against the static export with mocked APIs, including every screen rendered in English without missing messages.TestOutputLanguageSettings(PostgreSQL) plus agent and report language tests.An earlier build was also checked on a live test instance (language selector, English Agent output and report). The rebased build was verified with the automated checks above; the browser tests use mocked APIs.
🤖 Generated with Claude Code