Skip to content

aes: --cfg aes_backend documentation is no longer accurate #596

Description

@TechnoPorg

aes/lib.rs still mentions setting the aes_backend cfg to avx256 or avx512, but these options were removed in #580.

//! Note: Enabling VAES256 or VAES512 still requires specifying `--cfg
//! aes_backend = "avx256"` or `--cfg aes_backend = "avx512"` explicitly.

I'd happily open a PR to fix this, but one thing I'm not sure about is what to do about the use of this flag in CI, where you have some tests that were previously explicitly forcing the VAES backends, and now auto-detect them like anywhere else:

vaes256:
runs-on: ubuntu-latest
strategy:
matrix:
include:
- target: x86_64-unknown-linux-gnu
rust: stable
RUSTFLAGS: '-Dwarnings --cfg aes_backend="avx256"'

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions