Repository navigation
Conversation
The LE FieldBytesEncoding impls were replaced by the FIELD_ENDIANNESS const in RustCrypto#1831, but only Ed448 got it, so Decaf448 fell back to big endian.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1831 replaced the little endian
FieldBytesEncodingimpls with the newFIELD_ENDIANNESSconst, but onlyEd448gotByteOrder::LittleEndian.Decaf448now uses the default big endian order whileDecafScalar::to_repris little endian, so anything going throughbytes_to_uint, e.g.SecretKey::<Decaf448>::from_bytes(&scalar.to_repr()), gets the byte reversed scalar.Added the missing const and a test for the
SecretKeyround trip, which fails on master:Tested with: