Skip to content

Inconsistency between hash_into function names #462

Description

@brxken128

There's multiple differently named functions that all do the same thing - hash a password into a buffer:

  • argon2: .hash_password_into()
  • balloon-hash: .hash_into()
  • bcrypt-pbkdf: .finalize_into() (this one is understandable as it can be incremental)
  • scrypt: it's the only option available, via scrypt()
  • sha-crypt: does not provide the functionality at all

I personally think the easiest solution would be to rename balloon-hash' .hash_into() into .hash_password_into(), and although it'd be a breaking change it would unify the function names a little more.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions