Update documentation - #132
Conversation
Pin Sphinx and mermaid extension used to build the documentation.\n\nThis file makes it easy to create a virtualenv and install the exact packages tested when running 'make html' in docs. Optional runtime deps that enable autodoc imports are commented out.\n Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
|
||
| 1. Configure source and destination DSNs. | ||
| 2. Generate an ``orm.yaml`` file. | ||
| 3. Review and refine the schema definition. |
There was a problem hiding this comment.
This is good. It feels like it could be better to be clearer that 2 is automatic and that 3 is updating this. Something like:
2. Generate the default schema definition (orm.yaml file)
and leave 3 as it is perhaps?
There was a problem hiding this comment.
|
|
||
| .. code-block:: text | ||
|
|
||
| orm.yaml |
There was a problem hiding this comment.
orm.yaml is not updated by these operations.
There was a problem hiding this comment.
This line has been removed now.
|
|
||
| datafaker create-tables | ||
|
|
||
| Generate synthetic data: |
There was a problem hiding this comment.
Perhaps add that this generates 100 lines in each table?
There was a problem hiding this comment.
| Troubleshooting | ||
| ^^^^^^^^^^^^^^^ | ||
|
|
||
| * If you see a command not found error when running ``datafaker``, run the command using Poetry instead: ``poetry run datafaker`` |
There was a problem hiding this comment.
This is only for developers. Normal users will probably have installed DataFaker with pipx. I suppose "check it's installed"? I don't know.
There was a problem hiding this comment.
tim-band
left a comment
There was a problem hiding this comment.
Yes, this is good. Have a look at the suggestions and make improvements if you want. Thanks for doing this!
|
Thank you Tim! I will make the changes based on your comments above and merge the code after you have merged the |
Resolved #131
Summary
This PR updates and reorganises the Datafaker documentation to improve clarity, navigation, and onboarding for users. In particular, it adds a new tutorial covering the workflow required by Paul and Shipra for generating synthetic Camino data from Parquet files.
Changes
tutorial_parquet.rst), which serves as the primary guide for Paul and Shipra's use case.duckdb.rst) has been retained for the time being and can be removed later if Tim agrees thattutorial_parquet.rstprovides sufficient coverage.index.rstto:quickstart.rst.installation.rst.loan_data.rst) fromindex.rstbecause the example describes Turing's SqlSynthGen rather than Datafaker.requirements.txtfile for building the Sphinx documentation./datafaker/README.mdto include a link (https://safehr-data.github.io/datafaker/index.html) to the documentation GitHub Pages site.Future Work
The "Advanced" section would benefit from additional review and reorganisation. Further documentation improvements can be addressed in a subsequent documentation-focused PR.