Skip to content

Hasher needs internet - #95

Open
jeremyestein wants to merge 4 commits into
jeremy/make-grafana-viewablefrom
jeremy/hasher-needs-internet
Open

Hasher needs internet#95
jeremyestein wants to merge 4 commits into
jeremy/make-grafana-viewablefrom
jeremy/hasher-needs-internet

Conversation

@jeremyestein

Copy link
Copy Markdown
Collaborator

While I was performing #93 , I discovered there was an uncommitted config change that gave the hasher access to the internet at runtime, which it needs to access the key vault.

Add this, and while we're at it consolidate the proxy conf using yaml anchors and fix the annoying missing env var warning that docker compose gives every time you do anything.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.42%. Comparing base (9b0e98a) to head (296c8ab).

Additional details and impacted files
@@                      Coverage Diff                      @@
##           jeremy/make-grafana-viewable      #95   +/-   ##
=============================================================
  Coverage                         51.42%   51.42%           
=============================================================
  Files                                14       14           
  Lines                               595      595           
  Branches                             48       48           
=============================================================
  Hits                                306      306           
  Misses                              273      273           
  Partials                             16       16           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skeating skeating left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks tidy to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants