Skip to content

Fix: Remove sample app default credentials - #454

Merged
KarstenSchnitter merged 1 commit into
mainfrom
fix/sample-app-default-credentials
Oct 23, 2026
Merged

KarstenSchnitter merged 1 commit into
mainfrom
fix/sample-app-default-credentials

Conversation

@KarstenSchnitter

Copy link
Copy Markdown
Contributor

Summary

Removes the publicly known user / secret credentials from the deployable Spring Boot sample application.

Changes

  • Removes hard-coded credentials from Java configuration and application.yml.
  • Uses Spring Boot’s generated password for local development.
  • Prints generated local credentials in a readable development-only banner.
  • Requires Basic-auth credentials as CF manifest variables.
  • Activates the cloud profile in both CF manifests to suppress the local credential banner.
  • Updates the README and curl examples.
  • Adds regression tests ensuring the former credentials cannot authenticate.
  • Updates the default manifest to sap_java_buildpack_jakarta.

Verification

  • mvn -pl sample-spring-boot test
    • 5 tests passed.
  • Manually verified on Cloud Foundry:
    • Deployment fails before staging when credential variables are missing.
    • Deployment succeeds when credentials are supplied.
    • Supplied credentials authenticate successfully.
    • Generated credentials are not written to CF logs.

Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
@Felix-Griesau-SAP

Copy link
Copy Markdown
Contributor

🦔

@KarstenSchnitter
KarstenSchnitter merged commit 8bea2c3 into main Oct 23, 2026
3 checks passed
@KarstenSchnitter
KarstenSchnitter deleted the fix/sample-app-default-credentials branch October 23, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants