-
Notifications
You must be signed in to change notification settings - Fork 6
Added new PersonalData Annoations #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sthesse
wants to merge
6
commits into
SAP:main
Choose a base branch
from
sthesse:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ebda34c
update
sthesse 4297e7d
update
sthesse 40f3c45
Merge pull request #1 from sthesse/add/dpp_annotations
sthesse 17fa7e9
Extending @PersonalData.isPotentiallySensitive to entities
sthesse ec69937
addressing reviewers feedback
sthesse 99cf5a1
generation of schema
sthesse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -608,7 +608,9 @@ Constraints: | |
| - `sap:UserID` | ||
| - `sap:EndOfBusinessDate` | ||
| - `sap:BlockingDate` | ||
| - `sap:IsBlockedIndicator` | ||
| - `sap:EndOfRetentionDate` | ||
| - `sap:DataCategoryID` | ||
|
|
||
| Constraints: | ||
|
|
||
|
|
@@ -642,3 +644,31 @@ Constraints: | |
|
|
||
| - OPTIONAL | ||
| - Default: `true` | ||
|
|
||
| ### `x-sap-dpp-related-data-category-id` | ||
|
|
||
| - Type: `Array` | ||
| - Used at: [Schema Object](https://spec.openapis.org/oas/v3.0.3#schema-object) | ||
| - Description: The annotation value is an array of strings, enabling the assignment of multiple data categories to one entity or field. Data categories are entities describing a particular set of personal data with a similar usage, meaning, quality, and risk. The strings must adhere to the format of an Correlation ID corresponding to the concept name dataCategory in conjunction with an localIdentifier introduced herein (refer to [ORD Specification | Open Resource Discovery](https://open-resource-discovery.org/spec-v1#correlation-id)). | ||
|
|
||
| - Array Item: | ||
|
|
||
| - Type: `String` | ||
|
|
||
| Example: | ||
|
|
||
| ```json | ||
| { | ||
| "components": { | ||
| "schemas": { | ||
| "Product": { | ||
| "type": "object", | ||
| "x-sap-dpp-related-data-category-id": [ | ||
| "sap.s4com:dataCategory:SalesOrder", | ||
| "sap.s4com:dataCategory:PurchaseContract" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+661
to
+673
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a wrong example for OpenAPI v2.0:
|
||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pay attention at OpenAPI spec version