Adding "safe-guards" to avoid segfault in the GaussHitFinderSBN module

[mattiasotgia]

The issue

The introduction of the NextADCThreshold parameter in LArSoft/larreco#92 highlighted some minor bugs in the GaussHitFinderSBN module that made the code segfault for some edge case.

This PR aims at adding some safeguards to the code preventing the segfault to happen.

Description

The changes happens in three points of the code

1. After the peakFitterTool returns the peak parameters for each "candidate hit". Here we added a check for all "not finite" bounds, whereas the old version of the code was only checking for the positive side. Since the $\chi^2/\mathrm{ndf}$ is computed from all the fitted hits, $-\infty$ values were possible, and treated as "not pathological". This fixes those cases.
2. After all candidates have been fitted and failed fits treated accordingly, when computing the boundaries of the hits we added a check (line 501) making sure the start/end points where still withing the ROI range.
3. Finally after all the safe-guards at the end of the module are applied, we make sure (line 555) that no "boundary flip" has happened (i.e. start > end)

[mattiasotgia]

Adding @linyan-w as reviewer for SBND, adding this to SBND 2025 Gen2 Production

[cerati]

Please remove the " // THIS IS NOT USED" lines? or if there is a specific need for them, please explain. Everything else seems fine so I will approve in the mean time

[mattiasotgia]

Hi @cerati I addressed your comment. However I wanted to highlight that the comment was present since even if the hit filtering is enabled, filtered hits are not saved (since the lines 645--649 are commented out), so maybe we might need to check how this might be enabled correctly, to align it to the larreco module

[PetrilloAtWork]

A couple of comments to help documentation and future interpretation.
Technically it looks good to me.

[kjplows]

I remember the gotchas addressed by points 2 and 3.. The changes look good to me, approved! Thanks @mattiasotgia :)

[mattiasotgia]

Addressed @PetrilloAtWork's comments (thank you 🙏🏾). I've added a couple of lines regarding this issue (and a reference to the presentation where the issue is presented, SBN DocDB-47092

[SFBayLaser]

I'm happy to approve, have seen multiple presentations on this, the code changes are consistent with those presentations and, finally, it looks like Mattia has addressed other reviewer requests.

[PetrilloAtWork]

Thank you, @mattiasotgia.