WireMod Closure Update for sbncode develop#663
Open
gputnam wants to merge 21 commits into
Open
Conversation
…age of SignalROIF, rounding of floats, fixed scaling factors to 1 at al. )
…ff when using additive modification. Second I modified the interpolation that was stopping at bin center for bins at the borders, in this case we clamp the interpolation to the outer bin edge. Third I introduced a flag which allows WireMod to either use interpolation or pick up the scaling factor from the closest bin center.
hausnerh
reviewed
Jul 15, 2026
| fWireModuleLabelVec = pset.get<std::vector<art::InputTag>>("WireModuleLabelVec", std::vector<art::InputTag>()={"decon1droi"}); | ||
| fOutInstanceLabelVec = pset.get<std::vector<std::string>> ("OutInstanceLabelVec", {"PHYSCRATEDATA"}); | ||
| fDiagnosticOutput = pset.get< bool >("DiagnosticOutput", false); | ||
| fUseFloatPrecision = pset.get< bool >("UseFloatPrecision", false); |
Contributor
There was a problem hiding this comment.
Not a stopping comment, but do we want the float precision to default to false? I like having it as a fhicl parameter, but we should make sure that the defaults match the most common use-case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.