Adding in filter for 3D model of cathode for systematics#926
Conversation
|
OK, so, using cosmic data I created a 3D representation of the cathode, I integrated that into SBNDCode and tried to create a version of the gdml that removes the cathode. This was validated using cosmic MC and is ready to be merged and used to generate a systematic variation. |
tbwester
left a comment
There was a problem hiding this comment.
Overall implementation looks good. Personally I prefer a larsoft service with centralized, sbnd-level cathode config file instead of configuring within the filter fhicl. I can't comment on the GDML nor jsonnet files.
There was a problem hiding this comment.
Did you consider making this a larsoft service? Then this could be used elsewhere with unified experiment-defined configuration (not just set in the filter configuration fhicl)
|
This PR also requires this PR in sbnd_data: |
|
Looks fine to me. sbnd_cathode_v8.txt has 62 nans in it -- they tend to be at the ends of lines, or in batches near the edges. The policy is "outside" which I guess is conservative. Maybe extrapolate to fill these in? |
tomjunk
left a comment
There was a problem hiding this comment.
Looks okay, except for all those nans in sbnd_cathode_v8.txt
Description
Please provide a detailed description of the changes this pull request introduces.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?