Remove promises from api/cloud_api/email_templates/ - #2168
Merged
Conversation
evanugarte
force-pushed
the
20260713-less-mail
branch
from
July 25, 2026 17:49
966ae1c to
c024adb
Compare
plsdoant
reviewed
Jul 25, 2026
plsdoant
left a comment
plsdoant
left a comment
There was a problem hiding this comment.
In Mailer.js are we supposed to increment verification on line 91? or are we supposed to increment passwordReset
otherwise LGTM
plsdoant
approved these changes
Jul 25, 2026
weslayer
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
works, see screenshot