fix(lyric): 智能选择模式下 TTML 覆盖遵循格式优先级 - #105
Merged
Merged
Conversation
- shouldTryTTML → shouldTryTTMLByFormat:去除平台白名单判断, 仅按用户配置的格式优先级决定是否尝试 TTML 升级 - resolveTTMLOverlay:从「仅尝试主歌词所在平台」改为遍历 NCM+QM 依次尝试,修复主歌词平台 ≠ AMLL DB 平台时 TTML 命中失败、回退到低优先级 QRC 的问题
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
当歌词来源偏好为「智能选择」时,用户配置的歌词格式优先级(如
TTML > LYS > QRC > KRC > YRC > LRC)失效:根因
resolveTTMLOverlay只尝试「在线主歌词所在平台」的 AMLL TTML DB:改动
src/services/lyricResolve.tsshouldTryTTML→shouldTryTTMLByFormat(私有)platform: Platform参数与platform is "netease" | "qqmusic"类型守卫resolveTTMLOverlay的TTML_PLATFORMS常量resolveTTMLOverlay重写online.source.platform」改为遍历["netease", "qqmusic"]依次尝试验证
pnpm typecheck通过(tsc + vue-tsc)shouldTryTTML全仓 grep 确认无外部调用方依赖被移除的 export