Skip to content

feat: add static proxy and deterministic routing (M1-M2) - #7

Merged
SShogun merged 7 commits into
mainfrom
codex/m1-m2-sourcery-review
Oct 10, 2026
Merged

SShogun merged 7 commits into
mainfrom
codex/m1-m2-sourcery-review

Conversation

@SShogun

@SShogun SShogun commented Oct 10, 2026

Copy link
Copy Markdown
Owner

Summary

This consolidated PR replaces the separate M1 proxy and M2 routing PRs.

  • Adds the static HTTP data plane with streaming, cancellation, and graceful shutdown.
  • Adds deterministic route matching, cluster endpoint selection, and health checks.
  • Restricts the unauthenticated development listener to loopback and bounds request admission, body-read idle waits, and upstream response headers.
  • Adds protocol, shutdown, connection ownership, and resource-limit regressions. The review record documents each Sourcery finding, its disposition, and remaining M5/M6 scope.

Verification

GOCACHE=/tmp/gatehouse-gocache make verify passed on both final M1 and M2 source trees using Go 1.26.9. This includes vet, Staticcheck, Buf lint and compatibility checks, generated-file checks, shuffled unit tests, shuffled race tests, and govulncheck; no vulnerabilities were reported.

Review context

This includes the actionable corrections from PR #5. The upgrade-forwarding comment was a false positive for Go 1.26.9 because ReverseProxy uses ResponseController.Hijack through Unwrap; a real bidirectional upgrade regression covers it. Upstream transport-failure logging was already fixed in the included history.

Add immutable route compilation with precedence, ambiguity checks, and fuzz coverage. Add endpoint selection, health thresholds, and cancellable probe scheduling. This is a partial M2 checkpoint; listener configuration, telemetry integration, scheduler jitter, and remaining M2 gates are not included.
# Conflicts:
#	docs/Gatehouse_TESTING_CI.md
Copilot AI balanced review requested due to automatic review settings October 10, 2026 18:42
@sourcery-ai

sourcery-ai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Sorry @SShogun, your pull request is larger than the review limit of 150,000 diff characters

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@SShogun
SShogun merged commit a033631 into main Oct 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants