Repository navigation
ci: enable test, typecheck, and lint gates - #13
Merged
Merged
Conversation
Keep the storage event test focused on the key consumed by the hook; jsdom rejects the supplied cross-realm storageArea. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a strict no-emit config so the existing typecheck script validates library source, tests, and Vitest configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a TypeScript flat config, wire lint scripts for both workspace projects, and remove an empty destructuring parameter caught by the new rules. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enforce the existing package and example checks in PR CI, and keep generated coverage/build files out of formatting checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a strict no-emit TypeScript config for the library and a root ESLint flat config with lint scripts for both workspace projects. Fixes the jsdom StorageEvent test, a lint error in the example, and excludes generated build/coverage output from formatting checks.
Evidence
typecheckhad no package tsconfig;lint:checkhad no ESLint config and a malformed cache option.Merge Danger
Door: Two-way
Blast Radius: CI
No production behavior changes; the only source change is a test-only StorageEvent construction fix and a lint-required metadata signature simplification.