Skip to content

refactor: remove legacy console and unused leftovers - #151

Merged
kapustazh merged 2 commits into
developfrom
feature/remove-legacy-leftovers
Oct 8, 2026
Merged

kapustazh merged 2 commits into
developfrom
feature/remove-legacy-leftovers

Conversation

@kapustazh

@kapustazh kapustazh commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Remove the retired tabbed console, its 196 unused CSS lines, duplicate API
Dockerfile, and four unused helper functions. Current landing, MCP docs and
workspace routes stay in place; unknown paths now show the public landing
instead of falling through to the legacy console.

Move authentication and read-only evidence assertions to current surfaces.
The default Dockerfile remains canonical; update the evidence runner and its
references accordingly. Applied migrations, payment controls and demo packages
remain intact.

Scope and acceptance criteria

  • Remove audited legacy console and unused helpers.
  • Remove duplicate Dockerfile.api and update all active references.
  • Preserve authentication gating, read-only evidence, payment controls, and current routes.
  • Remove newly orphaned CSS without weakening accessibility checks.
  • No dependency, migration, or settlement algorithm changes.

Product and security invariants

  • Tenant isolation remains fail-closed.
  • Sponsor authorization, auditability, and daily caps remain enforced where applicable.
  • Recipients cannot modify sponsor controls or access sponsor-only data.
  • No secrets or sensitive runtime configuration included.
  • Non-applicable invariants explained below.

Invariant notes: existing payment and recovery logic stays intact. The unused
resumeSafeJobs wrapper is removed; startup recovery and outbox draining remain.
Current cabinet auth and evidence behavior is covered by migrated tests.

Validation

Pinned Node 24.19.0 / pnpm 11.19.0:

pnpm test: PASS, build + 80 files / 1060 tests
pnpm --filter @oneshot/web test: PASS, 17 files / 100 tests
pnpm test:browser: PASS, 8 tests including contrast and responsive checks
pnpm format:check, lint, typecheck: PASS
pnpm check:generated, validate:fixtures: PASS
Repository-wide pinned markdownlint-cli2: PASS, 214 files
git diff --check: PASS

Browser validation caught a damaged CSS comment during deletion; fixed and
reran web/browser suites. PostgreSQL integration tests were not run locally; remote CI passed them.

Independent review evidence

Gate A — exact candidate tree before push

  • Verdict: SKIPPED following the user's instruction to omit FreePi.
  • No PASS claimed.

Gate B — exact remote PR head

  • Verdict: SKIPPED following the same instruction.
  • Draft; all remote checks pass on head d8fa882.
  • CI: repository-policy, Markdown/Mermaid, ESLint/TypeScript (including unit and PostgreSQL integration tests), browser acceptance, and Workers build all PASS.

Risk and rollback

  • Residual risks: unknown paths now display the public landing. Removed helper exports have no repository callers; external consumers would need to stop importing them. Packages are private.
  • Rollback: revert this commit; no schema or data changes.

Human merge

  • A human owner has reviewed the evidence and will perform the merge.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
oneshot d8fa882 Oct 08 2026, 05:12 PM

@kapustazh kapustazh left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kapustazh
kapustazh marked this pull request as ready for review October 8, 2026 17:19
@kapustazh
kapustazh merged commit 87f18d5 into develop Oct 8, 2026
5 checks passed
@kapustazh
kapustazh deleted the feature/remove-legacy-leftovers branch October 8, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant