Repository navigation
fix(audio): log SDL audio driver and error when open fails (issue 99) - #110
Merged
Merged
Conversation
Log SDL_GetCurrentAudioDriver() after the audio subsystem starts, and SDL_GetError() with freq, channels, and format (S16LE/F32LE) when the open fails. Also log the init failure path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 99: a failed audio start on Linux says nothing about why. The game plays through SDL, but
waveOutOpen failed (MMRESULT 1)gives no clue whether the driver is wrong, the device is unavailable, or something else.This change adds two logs to
engine/host/hos_sdl.c:SDL_GetCurrentAudioDriver());SDL_GetError()), with the rate, channels and format asked for, when the audio init or the device open fails.Tested on Linux (PipeWire, SDL 3.4.20):
audio: SDL driver pipewire, and sound works;SDL_AUDIO_DRIVER=nosuchdriver):audio: SDL audio init failed (Audio target 'nosuchdriver' not available), and the game keeps running;nx2/test_nup_read_name.py,tests/test_crash_record.py,tests/test_switches_documented.py).You wrote on #99 that the next version would also write SDL's own error into the log when the sound device fails. This does that, so take it or keep your own, whichever fits better.
It does not close #99: the reporter has not confirmed sound yet.
🤖 Generated with Claude Code