Repository navigation
feat(vk): add Display mode and Screen selectors to Graphics menu - #116
Open
meansabine wants to merge 1 commit into
Open
meansabine wants to merge 1 commit into
meansabine wants to merge 1 commit into
Conversation
Replaces the Fullscreen toggle with a 3-way Display mode selector (Windowed, Borderless, Fullscreen) and adds a Screen (monitor) selector, both saved in hookshot_options.ini (fullscreen= and screen=). Assisted-by: Antigravity
Owner
|
Thanks for this! It touches the Windows display path, so I'll read the whole diff and test the three modes and the screen selector in game before merging. That will come after the performance work currently running, so it may take a day or two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players with multiple monitors or who want explicit control over Windowed, Borderless, and independent-flip Fullscreen could previously only toggle Fullscreen on or off on the current display. This replaces the Fullscreen toggle with a 3-way Display mode selector and adds a Screen (monitor) selector in the F1/Insert Graphics tab, saving both choices across restarts in
hookshot_options.ini.What changed
Windowed/Borderless/Fullscreen) inengine/gpu/vk/vk_menu.cpp,engine/gpu/vk/vk_menu.h,engine/host/display.c,engine/host/posix/display_sdl.c, andengine/host/hos_sdl.c:0= Windowed (WS_OVERLAPPEDWINDOW),1= Borderless (borderless over the monitor;WS_POPUPonly when VRR asks for it),2= Fullscreen (WS_POPUP+SWP_SHOWWINDOWfor independent flip on Windows;SDL_WINDOW_FULLSCREENunder SDL2).fullscreen=key inhookshot_options.ini(0,1,2) for backward compatibility with existing configs andrecomplauncher.json, and keepsF11/Alt+Enterin sync.Auto, or1..Nby monitor name and resolution):EnumDisplayMonitors/EnumDisplayDevicesWon Windows and SDL display APIs (hos_posix_display_count/hos_posix_display_name) on Linux, saved asscreen=inhookshot_options.ini.WM_APP + 11and on startup beforefullscreen_tick().recomplauncher.json,engine/readme.md,docs/SWITCHES.md,engine/docs/switches.json,tests/test_present_mode.py,tests/test_recomplauncher_json.py,tests/screensaver_test.c, and addedengine/tests/test_display_mode.py.Testing
HeyListenBuilderand tested in-game on Windows.clang/clang++):test_display_mode.py,test_present_mode.py,test_menu_rows.py,test_screensaver.py,test_alt_enter.py,test_menu_hit.py,test_menu_restart.py,test_windows_display_startup.py,test_update_offer.py,test_host_exports.py,test_utf8_paths.py,test_recomplauncher_json.py, andtest_switches_documented.pyall passed.Assisted-by: Antigravity