Repository navigation
docs(vk): a texture the upload budget holds back leaves its draw out - #117
Merged
Merged
Conversation
engine/docs/development.md said a held-back texture is sampled as the null descriptor (black) meanwhile. Since RX_VK_DEFER_SKIP=1 became the default (engine/gpu/vk/vk_draw.cpp, defer_skip_on), the draw that samples it is left out of that present instead; only RX_VK_DEFER_SKIP=0 draws it sampling the placeholder. The switch list is regenerated from the corrected table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
engine/docs/development.md(theRX_VK_UPLOAD_BUDGET_MSrow) said a texture held back by the upload budget is "sampled as the null descriptor (black) meanwhile". With the defaultRX_VK_DEFER_SKIP=1(engine/gpu/vk/vk_draw.cpp,defer_skip_on()and its use in the draw path) the draw that samples it is left out of that present and its descriptor set is not reused; onlyRX_VK_DEFER_SKIP=0draws it sampling the placeholder.docs/SWITCHES.mdandengine/docs/switches.jsonwithpython -I engine/scripts/list_switches.py, since they carry the table's text.python -I -B tests/test_switches_documented.py(inengine/): "both files are current".Docs only; no code changes.
🤖 Generated with Claude Code