Skip to content

docs(vk): a texture the upload budget holds back leaves its draw out - #117

Merged
Sacrappy merged 1 commit into
Sacrappy:mainfrom
Mooseca:docs-held-texture-skip
Nov 21, 2026
Merged

Sacrappy merged 1 commit into
Sacrappy:mainfrom
Mooseca:docs-held-texture-skip

Conversation

@Mooseca

@Mooseca Mooseca commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

engine/docs/development.md (the RX_VK_UPLOAD_BUDGET_MS row) said a texture held back by the upload budget is "sampled as the null descriptor (black) meanwhile". With the default RX_VK_DEFER_SKIP=1 (engine/gpu/vk/vk_draw.cpp, defer_skip_on() and its use in the draw path) the draw that samples it is left out of that present and its descriptor set is not reused; only RX_VK_DEFER_SKIP=0 draws it sampling the placeholder.

  • Corrected that sentence.
  • Regenerated docs/SWITCHES.md and engine/docs/switches.json with python -I engine/scripts/list_switches.py, since they carry the table's text.
  • python -I -B tests/test_switches_documented.py (in engine/): "both files are current".

Docs only; no code changes.

🤖 Generated with Claude Code

engine/docs/development.md said a held-back texture is sampled as the null
descriptor (black) meanwhile. Since RX_VK_DEFER_SKIP=1 became the default
(engine/gpu/vk/vk_draw.cpp, defer_skip_on), the draw that samples it is left
out of that present instead; only RX_VK_DEFER_SKIP=0 draws it sampling the
placeholder. The switch list is regenerated from the corrected table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Sacrappy
Sacrappy merged commit 6b7fde7 into Sacrappy:main Nov 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants