Skip to content

fix(launcher): the player's copy is the input game, and every release builds again - #122

Open
Xarishark wants to merge 3 commits into
Sacrappy:mainfrom
Xarishark:fix/launcher-rebuild-each-release
Open

Xarishark wants to merge 3 commits into
Sacrappy:mainfrom
Xarishark:fix/launcher-rebuild-each-release

Conversation

@Xarishark

@Xarishark Xarishark commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

An update to the RecompLauncher integration, after RecompLauncher's SDK upgrade

RecompLauncher's SDK upgrade (elripalda/RecompLauncher#429) makes named inputs the one way a recomplauncher.json asks the player for files: the old game field is deprecated (read only until RecompLauncher 1.0), every new release builds again by itself, and prepare.version and prepare.timeout leave the schema. This PR moves HeyListen's RecompLauncher integration to the new SDK. It's ready for review.

What players get

With RecompLauncher #429, every new release of a game with a setup step builds again by itself. When the launcher installs a new HeyListen release (or the player goes back to an older one), it runs the builder's --prepare again from their copy before the game starts. So the game a player plays is always the one their installed release builds, and the launcher no longer shows a version they aren't playing. That was the reason for this PR's first version, which stamped each release's tag into prepare.version. The launcher now does it on its own, so that stamping is undone here and nothing has to be bumped by hand.

The change

  • recomplauncher.json:
    • The player's copy moves from the old game field to the first input, game (role game, a file or a folder), with the same build check (check.nup_build_id: e0f3ccfa). Named inputs are now RecompLauncher's one way to ask for files. game is deprecated and read only until RecompLauncher 1.0.
    • prepare passes it as {input:game}.
    • prepare.version is removed: the launcher ignores it and builds every new release again.
    • prepare.timeout is removed: there's no time limit any more, and only an hour without output stops a step.
  • engine/tests/test_recomplauncher_json.py: checks the copy is that input (same build ID and label, file or folder), that prepare has no version or timeout, and that make_game.py still takes prepare's arguments with {input:game}. The DLSS test picks the DLSS input by its id now that there are two.
  • docs/recomplauncher.md: "When players build again" says every release builds again by itself. The prepare line uses {input:game} and says how long a step may run, and the Launcher Support table points at the input.
  • The first version's release tooling (tools/release/launcher_manifest.py and its use in make_launcher_zip.py, appimage.sh and check_release_linux.py) is reverted. The net diff against main is only the three files above.

How it was checked

  • engine/tests/test_recomplauncher_json.py: 19 tests pass with RECOMPLAUNCHER_SCHEMA set to the schema from RecompLauncher #429.
  • test_progress_lines.py passes.
  • In RecompLauncher's own testing for #429, a game whose input carries check.nup_build_id refused another build by name, took the right one, and set up and played.

Not run: a real HeyListen release installed through the new launcher.

…repare.version

RecompLauncher builds the game again (the prepare step) only when
prepare.version changes, and the repository's file kept "1". So after the
launcher installed a newer HeyListen release, a player who had set up once
kept playing the game folder the first release built, while the launcher
showed the new release and --play offered an update the launcher had
already installed.

tools/release/launcher_manifest.py writes the repository's file with
prepare.version set to the release's tag; the Windows zip
(make_launcher_zip.py) and the AppImage (appimage.sh) carry that copy, and
check_release_linux.py compares the AppImage's copy with it. Nothing else
in the file changes (a test checks it), and the repository's file keeps "1".
@Xarishark
Xarishark marked this pull request as ready for review November 21, 2026 21:40
@Xarishark Xarishark closed this Nov 21, 2026
@Xarishark Xarishark reopened this Nov 22, 2026
@Xarishark
Xarishark marked this pull request as draft November 22, 2026 05:34
@Xarishark Xarishark changed the title fix(release): each release's recomplauncher.json carries its tag as prepare.version fix(launcher): the player's copy is the input game, and every release builds again Nov 22, 2026
@Xarishark
Xarishark marked this pull request as ready for review November 22, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant