Repository navigation
Conversation
…repare.version RecompLauncher builds the game again (the prepare step) only when prepare.version changes, and the repository's file kept "1". So after the launcher installed a newer HeyListen release, a player who had set up once kept playing the game folder the first release built, while the launcher showed the new release and --play offered an update the launcher had already installed. tools/release/launcher_manifest.py writes the repository's file with prepare.version set to the release's tag; the Windows zip (make_launcher_zip.py) and the AppImage (appimage.sh) carry that copy, and check_release_linux.py compares the AppImage's copy with it. Nothing else in the file changes (a test checks it), and the repository's file keeps "1".
Xarishark
marked this pull request as ready for review
November 21, 2026 21:40
…tag as prepare.version" This reverts commit 1e74f71.
Xarishark
marked this pull request as draft
November 22, 2026 05:34
Xarishark
marked this pull request as ready for review
November 22, 2026 06:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An update to the RecompLauncher integration, after RecompLauncher's SDK upgrade
RecompLauncher's SDK upgrade (elripalda/RecompLauncher#429) makes named inputs the one way a
recomplauncher.jsonasks the player for files: the oldgamefield is deprecated (read only until RecompLauncher 1.0), every new release builds again by itself, andprepare.versionandprepare.timeoutleave the schema. This PR moves HeyListen's RecompLauncher integration to the new SDK. It's ready for review.What players get
With RecompLauncher #429, every new release of a game with a setup step builds again by itself. When the launcher installs a new HeyListen release (or the player goes back to an older one), it runs the builder's
--prepareagain from their copy before the game starts. So the game a player plays is always the one their installed release builds, and the launcher no longer shows a version they aren't playing. That was the reason for this PR's first version, which stamped each release's tag intoprepare.version. The launcher now does it on its own, so that stamping is undone here and nothing has to be bumped by hand.The change
recomplauncher.json:gamefield to the first input,game(rolegame, a file or a folder), with the same build check (check.nup_build_id:e0f3ccfa). Named inputs are now RecompLauncher's one way to ask for files.gameis deprecated and read only until RecompLauncher 1.0.preparepasses it as{input:game}.prepare.versionis removed: the launcher ignores it and builds every new release again.prepare.timeoutis removed: there's no time limit any more, and only an hour without output stops a step.engine/tests/test_recomplauncher_json.py: checks the copy is that input (same build ID and label, file or folder), thatpreparehas noversionortimeout, and thatmake_game.pystill takesprepare's arguments with{input:game}. The DLSS test picks the DLSS input by its id now that there are two.docs/recomplauncher.md: "When players build again" says every release builds again by itself. The prepare line uses{input:game}and says how long a step may run, and the Launcher Support table points at the input.tools/release/launcher_manifest.pyand its use inmake_launcher_zip.py,appimage.shandcheck_release_linux.py) is reverted. The net diff againstmainis only the three files above.How it was checked
engine/tests/test_recomplauncher_json.py: 19 tests pass withRECOMPLAUNCHER_SCHEMAset to the schema from RecompLauncher #429.test_progress_lines.pypasses.check.nup_build_idrefused another build by name, took the right one, and set up and played.Not run: a real HeyListen release installed through the new launcher.