A couple more minor bug fixes - #71
Open
lsgunth wants to merge 2 commits into
Open
Conversation
vid is 16 bits wide but is printed with PRIx8. gcc accepts it, since the argument is promoted to int either way, but clang rejects it under -Werror. The compiler builds in CI configure with -Dlibnvme=disabled, which makes libnvme a disabler and skips the examples entirely, so nothing has been compiling this with clang. Signed-off-by: Logan Gunthorpe <logan.gunthorpe@eideticom.com>
VS.MJR prints the tertiary version and VS.TER the major one, so the example reports the wrong controller version. Signed-off-by: Logan Gunthorpe <logan.gunthorpe@eideticom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed a couple more minor issues in the code the other day and made a couple patches for them:
Use the correct format specifier when printing the vid. It is a 16bit value but was printed with an 8 bit specifier in the README example and identify.c
In regs.c, VS_TERM and VS_MJR were incorrectly ordered