Repository navigation
Conversation
Generate the Tenkai profile v2 block from the shipped job document and refuse a deploy/tenkai.toml that does not match. Dependents require kako.jobs at 1.0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124
The Tenkai product entry now provides the job-submission contract dependents
already require.
deploy/tenkai.tomlends with a profile v2 block thatprovides"kako.jobs" = "1.0.0". That version is generated from the shippedJSON job document (
JobFile/ScoringFile).scripts/validate-release.shrefuses a product whose profile does not match.
Reuse decision
Reuse Tenkai
[compatibility]v2providesand the generate-then-checkpattern already used by sibling products. The new edge is kako's job-document
field map plus the committed
deploy/tenkai.toml. Contract id iskako.jobsso existing optional
requiresstay valid. No Tenkai client and no newjob-submit endpoint.
Lane
feat/124.worktrees/issue-1248412d31207a90c64034529977d2337300c122f4d9834427405c5a5aeca31661921d68c9215515820Verification
cargo fmt --all -- --checkcargo build --locked --workspace --all-targetscargo clippy --locked --workspace --all-targets -- -D warningscargo clippy --locked -p kako-source-sekai --features sekai-client --all-targets -- -D warningscargo test --locked --workspacecargo test --locked -p kako-source-sekai --features sekai-clientbash scripts/validate-workflow-skills.shpython3 scripts/adr-index --checkbash scripts/validate-release.sh(printstenkai-profile: kako.jobs 1.0.0 ok)Focused coverage in
crates/kako/tests/release_packaging.rsandkako::job_contractunit tests: committed product matches the generated v2profile; a mutated provides-version, contract id, or profile version is
refused; Python parse of
JobFileagrees with the Rust field list.Autoreview
AUTOREVIEW_CODEX_CONFIG=model_provider=cliproxyapi "$AUTOREVIEW" --mode local --engine codexClean: no accepted/actionable findings.
Simplify-change
Kept the dual generators (Rust for in-crate tests, Python for
validate-release.shwith no cargo). Kept the explicit version-table matcharm so editing the live field list fails closed instead of silently staying
at 1.0.0. Dropped nothing else from the Issue.
Compatibility
0.1.0; the contract version is independent.version = 2is required by Tenkai ADR 0043. Servers older thanprofile v2 refuse this manifest.
providesonly. Dependents keep their own optionalrequires.Validate-behavior
Skipped: no operator-facing UI, CLI, or HTTP flow. Acceptance is the
committed profile and the release check, covered by the tests above.
Agent Transcript
Goal: Land kako #124 so the Tenkai product provides
kako.jobsat a generated stable version.Key decisions:
kako.jobsat1.0.0so dependents' existing optional requires stay valid.kako@<product.version>, matching sibling generate-then-check.JobFileforvalidate-release.sh.Changes made:
deploy/tenkai.toml: profile v2provides"kako.jobs" = "1.0.0".kako::job_contractplusscripts/tenkai-profile.py: generate and check.Verification:
validate-release.sh: passed.Skipped/deferred: