Repository navigation
File service - #411
Open
abdellah257 wants to merge 11 commits into
Open
File service#411abdellah257 wants to merge 11 commits into
abdellah257 wants to merge 11 commits into
Conversation
abdellah257
requested review from
Junjiequan,
bolmsten and
nitrosx
and removed request for
bolmsten
August 25, 2026 12:21
abdellah257
force-pushed
the
file-service
branch
2 times, most recently
from
August 25, 2026 12:56
2f28856 to
a9cbc8e
Compare
abdellah257
force-pushed
the
file-service
branch
from
August 25, 2026 13:01
a9cbc8e to
1fbcd01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Merge contains changes that covers multiple aspects / features / improvements, including:
fileendpoints support, to download/stream a single file in raw format.hdfviewing service, that can be served withfile/openendpoint.directoryin POST requests, to make sure the directory can be resolved directly from thedataset. This closes the big issue of given access to adirectorythat is unrelated to a givendataset.allowedDataDirectory.uploadendpoint, currently still unsafe to use.Changes:
new endpoints:
/file/file/download/file/stream/file/opennew configuration example:
{ "zipDir": "/tmpZip", "zipRetentionMillis": 3600000, "fileLinkRetentionMillis": 3600000, "jwtSecret": "secret123", "sessionSecret": "fj9832mnsaf3j9adsa", "facility": "ILL", "allowedDataDirectory": "/data", "directoryPathPattern": "/data/{sourceFolder}/{type}", "requiredKeywords": ["sourceFolder", "type"], "hdfViewServiceUrl": "https://hdf-viewer.example.org", "routeBasePath": "", "publicOrigin": "https://zip-service.example.org", "scicatApiBasePath": "https://scicat.example.org", "scicatApiAccessToken": "<scicatServiceAccountToken>", "testData": { "jwt": "<jwtToken>", "files": ["<testFileName1>", "<testFileName2>", "<testFileName3>"] } }Tests included/Docs Updated?