Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. Summary by CodeRabbit
WalkthroughThe Changeswcurl manifest update
Priority: ⬇️ Low Merge Risk: 🟡 Moderate · up to A fresh wcurl installation can leave the command unusable until curl is installed separately. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Some tools did not complete. Review the errors below. 🔧 Biome (2.5.10)bucket/wcurl.jsonBiome could not lint this file: configuration resulted in errors. Check the repository's Biome configuration and plugins. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: f48f2eed-78e1-412d-9ead-bc016dd925eb
📒 Files selected for processing (1)
bucket/wcurl.json
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
|
All changes look good. Wait for review from human collaborators. wcurl
|
There was a problem hiding this comment.
#6117 (comment)
WSL'sbashis very slow as I tried... So when I modify the manifest, I just keepshand addbusyboxas depends.
To be honest, I share the same concern. Since Git no longer creates a bash shim (#7459), running bash will default to WSL's bash whenever WSL is enabled. Until this issue is resolved, I think it's best to keep the original manifest design. I'd suggest dropping these changes; otherwise, this PR will likely remain on hold.
Fix
homepageorderPoint
urlto thewcurlscript instead of the entire archive.Move
dependstosuggest& removebusyboxdependency (Scoop automatically creates a shim to bash)Use conventional PR title:
<manifest-name[@version]|chore>: <general summary of the pull request>I have read the Contributing Guide