feat: redesign the weather overlay and add a temperature curve - #10
Open
lucasclgibson wants to merge 2 commits into
Open
feat: redesign the weather overlay and add a temperature curve#10lucasclgibson wants to merge 2 commits into
lucasclgibson wants to merge 2 commits into
Conversation
Replace the app-header component and glass cards with plain markup on a scrim, so the condition photograph stays and the type carries the screen. - Make the temperature the hero and give portrait a real layout - Draw the day's temperature as a smoothed curve with clock marks - Step long city names down a size so they cannot overflow - Set the background by class rather than an inline style
This should be an impossible state for a few reasons:
|
- Mirrors the calendar's clock: same formatting, same thirty second tick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the four condition photographs and redesigns everything on top of them.
<app-header>; the date line and brand logo are now plain markup fed by SDK helpersbody.style.backgroundImage; error and forecast visibility likewiseBundle drops from 5.67 MB to 4.50 MB despite keeping the photographs, since the removed component graph outweighed them.
Note: the curve is forward-looking only. Showing the elapsed part of the day needs historical hours, which OpenWeatherMap puts behind One Call 3.0.