refactor(test): use captureScreenshot helper from @screenly/edge-apps - #9
Draft
nicomiguelino wants to merge 1 commit into
Draft
refactor(test): use captureScreenshot helper from @screenly/edge-apps#9nicomiguelino wants to merge 1 commit into
nicomiguelino wants to merge 1 commit into
Conversation
- Replace the manual Playwright context/page/mock/screenshot boilerplate with the new captureScreenshot helper, for both the main and no-api-key resolution loops - Pin @screenly/edge-apps to 26.8.0 Draft: depends on Screenly/edge-apps-library#78 being merged and released as 26.8.0 first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e/screenshots.spec.tsto use the newcaptureScreenshot(browser, options)helper from@screenly/edge-apps/test/screenshotsinstead of the manually duplicated Playwright context/page/mock/screenshot boilerplate, for both the main andno-api-keyresolution loops.@screenly/edge-appsto26.8.0inpackage.json.screenshots/output for review.Draft — depends on Screenly/edge-apps-library#78 being merged and released as
26.8.0on npm first.bun.lockis intentionally not included in this commit; it'll be regenerated once26.8.0is actually published.Test plan
bun run type-checkbunx prettier --check package.json e2e/screenshots.spec.tsbun run screenshots(to be run once26.8.0is published andbun installsucceeds)