Repository navigation
fix: support version 3 Grok Bot gateway descriptors - #145
Open
tomer-ben-david wants to merge 1 commit into
Open
tomer-ben-david wants to merge 1 commit into
tomer-ben-david wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: ff9bdc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The CLI can read a single encrypted gateway entry from a v3 descriptor while continuing to reject ambiguous entries. Grok Bot now writes
{ version: 3, entries: { ... } }, but CLI 0.12.4 rejects it withUnsupported Grok Bot gateway descriptor version 3, leavingdoctorunable to use the app session andbots listfailing before its gateway request.Goals
Restore authenticated commands for v3 descriptors containing one encrypted gateway entry, retaining v1/v2 compatibility and existing validation errors.
Non-goals
Change account selection, token requirements, entry expiry, or Safe Storage decryption.
Solution
Accept version 3 in the shared session reader and process its
entriesthrough the existing version 2 path. Parameterize the entry tests over v2/v3, verify session inspection reports usable, and move the unsupported-version fixture to v4. Refresh the committed bundle and add a patch changeset.Next steps
Release through the existing Changesets workflow after merge.
Verification
node --test test/app-session.test.js: 22 passed; also passed on Node 22.23.1.npm run check: validation, build, artifact validation, and typecheck passed; unit tests passed 445/446. The history test attest/history.test.js:204fails with0 !== 1; the same failure was reproduced in a detached checkout of unchanged upstream43499fa.npm run test:routes: 97 passed.git diff --checkpassed.doctorreports the v3 app session usable andbots list --jsonreturns the roster.