Conversation
…ble to the process --cache-gb at or above the usable memory (cgroup limit when set, else physical RAM) stalled the render at the memory ceiling with no output and no log line. Print one warning to stderr. Nothing is clamped. Complements ScrollPrize#1695, which covers the torn-TIFF half of ScrollPrize#1404. Refs ScrollPrize#1404 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@nerln is attempting to deploy a commit to the scroll Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1404 (the
--cache-gbhalf). Prior work: #1415 addressed both halves of the issue (a clamp plus a torn-TIFF check) and was closed by the repository time limit without a human review; the torn-TIFF half is now in #1695. This PR only adds the warning the issue asks for on the--cache-gbside. Nothing is clamped and no default changes.--cache-gb(default 16) at or above the memory the process can use made the render sit at the memory ceiling with no output and no log line, indistinguishable from a slow render (the report in #1404 is a Docker host with a 15 GB limit). The tool now prints one line to stderr when the requested cache is not below the usable memory: the cgroup limit when one is set (memory.maxormemory.limit_in_bytes), otherwise physical RAM. On Windows there is no check.Reproduced on main (
1f544fa71) with a 3-slice render of a PHerc0125 segment, on a 16 GB machine:@hendrikschilling, you merged #1528 on this file: could you take a look when you have a moment?
The patch was prepared with Claude Code under my direction; I built it and ran the reproduction above locally.