Repository navigation
Remove hardcoded runtime directory - #569
Open
WhyNotHugo wants to merge 1 commit into
Open
WhyNotHugo wants to merge 1 commit into
WhyNotHugo wants to merge 1 commit into
Conversation
Replace a hardcoded runtime directory location with the actual value from XDG_RUNTIME_DIR. Fixes: ShadowBlip#568
ShadowApex
approved these changes
Nov 12, 2026
ShadowApex
left a comment
Collaborator
There was a problem hiding this comment.
This is a good change. Thanks for this!
ShadowApex
requested changes
Nov 12, 2026
ShadowApex
left a comment
Collaborator
There was a problem hiding this comment.
It looks like this broke the test in pipe_manager_test.gd. It might be good to use a fallback path if XDG_RUNTIME_DIR is not defined.
Author
|
Do you mean using a fallback path for the test, or for the actual logic itself? |
Collaborator
@WhyNotHugo in the code. "Fixing" the test so it passes would defeat the point of the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace a hardcoded runtime directory location with the actual value from XDG_RUNTIME_DIR.
Fixes: #568