Skip to content

Remove hardcoded runtime directory - #569

Open
WhyNotHugo wants to merge 1 commit into
ShadowBlip:mainfrom
WhyNotHugo:rundir
Open

WhyNotHugo wants to merge 1 commit into
ShadowBlip:mainfrom
WhyNotHugo:rundir

Conversation

@WhyNotHugo

Copy link
Copy Markdown

Replace a hardcoded runtime directory location with the actual value from XDG_RUNTIME_DIR.

Fixes: #568

Replace a hardcoded runtime directory location with the actual value
from XDG_RUNTIME_DIR.

Fixes: ShadowBlip#568

@ShadowApex ShadowApex left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change. Thanks for this!

@ShadowApex ShadowApex left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this broke the test in pipe_manager_test.gd. It might be good to use a fallback path if XDG_RUNTIME_DIR is not defined.

@WhyNotHugo

Copy link
Copy Markdown
Author

Do you mean using a fallback path for the test, or for the actual logic itself?

@pastaq

pastaq commented Nov 22, 2026

Copy link
Copy Markdown
Collaborator

Do you mean using a fallback path for the test, or for the actual logic itself?

@WhyNotHugo in the code. "Fixing" the test so it passes would defeat the point of the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hardcoded XDG_RUNTIME_DIR

3 participants