Repository navigation
fix(Settings): the settings lists scroll to the focused row - #571
Merged
Merged
Conversation
With a larger UI scale, the Settings category list on the left no longer fits the screen, and moving down it with the D-pad took the focus below the visible part without scrolling: the scroll bar had to be dragged by hand. Its ScrollContainer, and the game settings' one built the same way, did not set follow_focus, which the General, Library and Plugins pages already do. follow_focus is set now on the category lists of Settings and of a game's settings, and on the Display, Network, Bluetooth and Disks pages, which grow past the screen the same way at a larger scale. It is also set on the install options dialog, whose fixed-size list gets a row per install option, and on the first-run language and network select screens, which had nothing scrolling them to the focused row.
ShadowApex
approved these changes
Nov 12, 2026
ShadowApex
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Thanks for this!
Contributor
|
🎉 This PR is included in version 0.47.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a larger UI scale, the Settings category list on the left no longer fits the screen, and moving down it with the D-pad took the focus below the visible part without scrolling: the scroll bar had to be dragged by hand. Its ScrollContainer, and the game settings' one built the same way, did not set follow_focus, which the General, Library and Plugins pages already do.
follow_focus is set now on the category lists of Settings and of a game's settings, and on the Display, Network, Bluetooth and Disks pages, which grow past the screen the same way at a larger scale.
It is also set on the install options dialog, whose fixed-size list gets a row per install option, and on the first-run language and network select screens, which had nothing scrolling them to the focused row.