Skip to content

fix(Settings): the settings lists scroll to the focused row - #571

Merged
ShadowApex merged 1 commit into
ShadowBlip:mainfrom
spycat88:fix-settings-follow-focus
Nov 12, 2026
Merged

ShadowApex merged 1 commit into
ShadowBlip:mainfrom
spycat88:fix-settings-follow-focus

Conversation

@spycat88

Copy link
Copy Markdown
Contributor

With a larger UI scale, the Settings category list on the left no longer fits the screen, and moving down it with the D-pad took the focus below the visible part without scrolling: the scroll bar had to be dragged by hand. Its ScrollContainer, and the game settings' one built the same way, did not set follow_focus, which the General, Library and Plugins pages already do.

follow_focus is set now on the category lists of Settings and of a game's settings, and on the Display, Network, Bluetooth and Disks pages, which grow past the screen the same way at a larger scale.

It is also set on the install options dialog, whose fixed-size list gets a row per install option, and on the first-run language and network select screens, which had nothing scrolling them to the focused row.

With a larger UI scale, the Settings category list on the left no longer
fits the screen, and moving down it with the D-pad took the focus below
the visible part without scrolling: the scroll bar had to be dragged by
hand. Its ScrollContainer, and the game settings' one built the same
way, did not set follow_focus, which the General, Library and Plugins
pages already do.

follow_focus is set now on the category lists of Settings and of a
game's settings, and on the Display, Network, Bluetooth and Disks pages,
which grow past the screen the same way at a larger scale.

It is also set on the install options dialog, whose fixed-size list gets
a row per install option, and on the first-run language and network
select screens, which had nothing scrolling them to the focused row.

@ShadowApex ShadowApex left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this!

@ShadowApex
ShadowApex merged commit 429817d into ShadowBlip:main Nov 12, 2026
3 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.47.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@spycat88
spycat88 deleted the fix-settings-follow-focus branch November 12, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants