Repository navigation
Conversation
Coverage Report
|
|
✅ E2E not needed
No E2E application was selected for this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Checkout Kit ships its Web SDK as a single NPM package and CDN artifacts. Today, the shipped Web graph has no third-party runtime dependencies: its components compose through Checkout Kit workspace packages and the build bundles that graph.
The existing lockfile, package verification, and dependency-boundary checks make builds reproducible and validate module boundaries, but they do not prevent a future component from adding a third-party runtime dependency independently. If two shipped modules select incompatible versions of a shared library, dependency resolution can produce multiple bundled copies. This is particularly risky for singleton or global-state libraries, and also increases bundle size and makes security/upgrade ownership ambiguous.
How this helps
The new check rejects
dependencies,optionalDependencies, andpeerDependenciesthat are not@shopify/checkout-kit-*workspace:*dependencies in the shipped Web package, components, and internal packages. It intentionally permitsdevDependencies, so a module can continue to own its test/build tooling without affecting the delivered artifact.The check runs both in
lint:dependenciesand beforebuild:npm; therefore package and publish builds cannot silently produce a new runtime dependency graph. Adding a third-party runtime dependency now requires an explicit product-level dependency policy and integration coverage rather than an incidental submodule manifest change.Examples prevented
Validation
dev web lintdev web build