Skip to content

fix(ci): restore cross-platform validation - #2

Merged
hanhan-sigmaz-code merged 3 commits into
mainfrom
fix/ci-workflow
Oct 30, 2026
Merged

hanhan-sigmaz-code merged 3 commits into
mainfrom
fix/ci-workflow

Conversation

@hanhan-sigmaz-code

@hanhan-sigmaz-code hanhan-sigmaz-code commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

CI previously failed workflow validation because job-level env referenced runner.temp, which is unavailable in that context. Initialize the isolated runtime paths after runner startup so setup and tests can execute on macOS and Windows.

The first working CI runs also exposed test-environment dependencies. This change:

  • Gives the offline review-price test an isolated configuration, a dummy key and a pinned model instead of relying on personal credentials or cached settings.
  • Uses asynchronous fixture copying to preserve the standalone installation test's Chinese and space-containing paths on Windows with Node.js 22.
  • Runs test files sequentially to reduce competing browser renders during real-time recording tests. All existing assertions and the macOS/Windows × Node.js 22/24 matrix remain enabled.

Validation:

  • actionlint 1.7.12 and git diff --check pass.
  • Local full suite: 208 passed, 0 failed, 1 existing skip.

Required CI checks are intentionally deferred. The active main ruleset requires one approving review, dismisses stale approvals, requires resolved review conversations, blocks force pushes and deletion, and has no bypass actors. This PR needs an independent approval before merge.

@hanhan-sigmaz-code hanhan-sigmaz-code changed the title fix(ci): initialize runtime paths after runner startup fix(ci): restore cross-platform validation Oct 30, 2026
@hanhan-sigmaz-code
hanhan-sigmaz-code merged commit 367f3ad into main Oct 30, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant